CVS log for pgsql/src/backend/utils/adt/ascii.c

Up to [PostgreSQL CVS Repository] / pgsql / src / backend / utils / adt

Request diff between arbitrary revisions - Display revisions graphically

Keyword substitution: kv
Default branch: MAIN

Update copyright for the year 2010.

Update copyright for 2009.

Update copyrights in source tree to 2008.

Fix the inadvertent libpq ABI breakage discovered by Martin Pitt: the
renumbering of encoding IDs done between 8.2 and 8.3 turns out to break 8.2
initdb and psql if they are run with an 8.3beta1 libpq.so.  For the moment
we can rearrange the order of enum pg_enc to keep the same number for
everything except PG_JOHAB, which isn't a problem since there are no direct
references to it in the 8.2 programs anyway.  (This does force initdb
unfortunately.)

Going forward, we want to fix things so that encoding IDs can be changed
without an ABI break, and this commit includes the changes needed to allow
libpq's encoding IDs to be treated as fully independent of the backend's.
The main issue is that libpq clients should not include pg_wchar.h or
otherwise assume they know the specific values of libpq's encoding IDs,
since they might encounter version skew between pg_wchar.h and the libpq.so
they are using.  To fix, have libpq officially export functions needed for
encoding name<=>ID conversion and validity checking; it was doing this
anyway unofficially.

It's still the case that we can't renumber backend encoding IDs until the
next bump in libpq's major version number, since doing so will break the
8.2-era client programs.  However the code is now prepared to avoid this
type of problem in future.

Note that initdb is no longer a libpq client: we just pull in the two
source files we need directly.  The patch also fixes a few places that
were being sloppy about checking for an unrecognized encoding name.

Update CVS HEAD for 2007 copyright.  Back branches are typically not
back-stamped for this.

Remove 576 references of include files that were not needed.

Sort reference of include files, "A" - "F".

Update copyright for 2006.  Update scripts.

Standard pgindent run for 8.1.

Suppress signed-vs-unsigned-char warnings.

Update copyrights that were missed.

Add support for Latin9 encoding in to_ascii().  Jaime Casanova

Pgindent run for 8.0.

Update copyright to 2004.

$Header: -> $PostgreSQL Changes ...

Various message fixes, among those fixes for the previous round of fixes

Fix some copyright notices that weren't updated.  Improve copyright tool
so it won't miss 'em again.

pgindent run.

Error message editing in utils/adt.  Again thanks to Joe Conway for doing
the bulk of the heavy lifting ...

Fix a *second* buffer overrun bug in to_ascii().  Grumble.

Fix a *second* buffer overrun bug in to_ascii().  Grumble.

Fix a *second* buffer overrun bug in to_ascii().  Grumble.

Fix buffer overrun in to_ascii(), per report from Guido Notari.

Fix buffer overrun in to_ascii(), per report from Guido Notari.

Fix buffer overrun in to_ascii(), per report from Guido Notari.

Remove #ifdef MULTIBYTE per hackers list discussion.

New pgindent run with fixes suggested by Tom.  Patch manually reviewed,
initdb/regression tests pass.

Another pgindent run.  Fixes enum indenting, and improves #endif
spacing.  Also adds space for one-line comments.

pgindent run on all C files.  Java run to follow.  initdb/regression
tests pass.

Commit Karel's patch.

-------------------------------------------------------------------
Subject: Re: [PATCHES] encoding names
From: Karel Zak <zakkr@zf.jcu.cz>
To: Peter Eisentraut <peter_e@gmx.net>
Cc: pgsql-patches <pgsql-patches@postgresql.org>
Date: Fri, 31 Aug 2001 17:24:38 +0200

On Thu, Aug 30, 2001 at 01:30:40AM +0200, Peter Eisentraut wrote:
> > 		- convert encoding 'name' to 'id'
>
> I thought we decided not to add functions returning "new" names until we
> know exactly what the new names should be, and pending schema

 Ok, the patch not to add functions.

> better
>
>     ...(): encoding name too long

 Fixed.

 I found new bug in command/variable.c in parse_client_encoding(), nobody
probably never see this error:

if (pg_set_client_encoding(encoding))
{
	elog(ERROR, "Conversion between %s and %s is not supported",
                     value, GetDatabaseEncodingName());
}

because pg_set_client_encoding() returns -1 for error and 0 as true.
It's fixed too.

 IMHO it can be apply.

		Karel
PS:

    * following files are renamed:

src/utils/mb/Unicode/KOI8_to_utf8.map  -->
        src/utils/mb/Unicode/koi8r_to_utf8.map

src/utils/mb/Unicode/WIN_to_utf8.map  -->
        src/utils/mb/Unicode/win1251_to_utf8.map

src/utils/mb/Unicode/utf8_to_KOI8.map -->
        src/utils/mb/Unicode/utf8_to_koi8r.map

src/utils/mb/Unicode/utf8_to_WIN.map -->
        src/utils/mb/Unicode/utf8_to_win1251.map

   * new file:

src/utils/mb/encname.c

   * removed file:

src/utils/mb/common.c

--
 Karel Zak  <zakkr@zf.jcu.cz>
 http://home.zf.jcu.cz/~zakkr/

 C, PostgreSQL, PHP, WWW, http://docs.linux.cz, http://mape.jcu.cz

Remove dashes in comments that don't need them, rewrap with pgindent.

pgindent run.  Make it all clean.

Change Copyright from PostgreSQL, Inc to PostgreSQL Global Development Group.

Minor cleanup.

Tired of seeing these warnings ...

> I had to back out the patch. It only compiles with multi-byte enabled.

 Ooops, I forget... here it is again.

> > >  If encoding is not supported returns ERROR.

 and if multibyte not enabled too....


 Thanks.

                                Karel
~

Back out to_ascii patch from Karel.

Add missing files from Karel, tip from Jan.